Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sidebar: auto bug #320

Closed
wants to merge 7 commits into from
Closed

fix sidebar: auto bug #320

wants to merge 7 commits into from

Conversation

shaodahong
Copy link
Contributor

@shaodahong shaodahong commented May 2, 2018 •
edited
Loading

@shaodahong shaodahong mentioned this pull request May 2, 2018
Closed
@shaodahong
Copy link
Contributor Author

need more advice

Because the sidebarDepth is a maximum of 3, there is no need to resolveHeaders, but later support nested sidebar need to be modified

I hope more support nested sidebar

@ulivz
Copy link
Member

ulivz commented May 2, 2018

Thanks for your contribution!

See: #319 (comment)

BTW, You shouldn't compromise the functionality of sidebar: auto when you develop any new features.

@ulivz ulivz closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaodahong @ulivz